fluo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ctubbsii <...@git.apache.org>
Subject [GitHub] incubator-fluo pull request #825: fixes #823
Date Sat, 22 Apr 2017 02:35:47 GMT
Github user ctubbsii commented on a diff in the pull request:

    https://github.com/apache/incubator-fluo/pull/825#discussion_r112800377
  
    --- Diff: modules/api/src/main/java/org/apache/fluo/api/data/Bytes.java ---
    @@ -355,6 +354,36 @@ public static final Bytes of(String s, Charset c) {
       }
     
       /**
    +   * Checks if this has the passed prefix
    +   * 
    +   * @param prefix
    +   * @return true or false
    +   */
    +  public boolean startsWith(Bytes prefix) {
    +    for (int i = 0; i < prefix.length; i++) {
    --- End diff --
    
    prefix (and suffix in next method) should be checked for null with `Objects.requiresNonNull(prefix)`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message