fluo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From keith-turner <...@git.apache.org>
Subject [GitHub] incubator-fluo-recipes pull request #129: Reduced creation of intermediate S...
Date Fri, 28 Apr 2017 17:21:00 GMT
Github user keith-turner commented on a diff in the pull request:

    https://github.com/apache/incubator-fluo-recipes/pull/129#discussion_r113979089
  
    --- Diff: modules/core/src/main/java/org/apache/fluo/recipes/core/map/CollisionFreeMap.java
---
    @@ -194,12 +199,11 @@ void process(TransactionBase tx, Bytes ntfyRow, Column col) throws
Exception {
           tx.setWeakNotification(ntfyRow, col);
         }
     
    -    byte[] dataPrefix = ntfyRow.toArray();
    --- End diff --
    
    It should.   I added a sanity check at the beginning of process to ensure it starts with
updatePrefix


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message