fluo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] srikailash commented on a change in pull request #966: fluo-env.sh now supports FLUO_JAVA_OPTS set in environment
Date Thu, 01 Jan 1970 00:00:00 GMT
srikailash commented on a change in pull request #966: fluo-env.sh now supports FLUO_JAVA_OPTS
set in environment
URL: https://github.com/apache/fluo/pull/966#discussion_r149472157
 
 

 ##########
 File path: modules/distribution/src/main/config/fluo-env.sh
 ##########
 @@ -35,7 +35,12 @@ export FLUO_CONN_PROPS="${FLUO_CONN_PROPS:-${conf}/fluo-conn.properties}"
 ## Fluo log4j configuration
 export FLUO_LOG4J_CONFIG="${FLUO_LOG4J_CONFIG:-${conf}/log4j.properties}"
 ## Java options for Fluo command
-JAVA_OPTS=("-Dlog4j.configuration=file:${FLUO_LOG4J_CONFIG}")
+JAVA_OPTS="-Dlog4j.configuration=file:${FLUO_LOG4J_CONFIG}"
+##Prepending JAVA_OPTS with FLUO_JAVA_OPTS
+for var in "${FLUO_JAVA_OPTS[@]}"
+do
+	JAVA_OPTS=("$var $JAVA_OPTS")
 
 Review comment:
   Yes this make sense .. will submit an updated PR .

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message