fluo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] keith-turner commented on a change in pull request #969: [WIP] Issue-967
Date Thu, 01 Jan 1970 00:00:00 GMT
keith-turner commented on a change in pull request #969: [WIP] Issue-967
URL: https://github.com/apache/fluo/pull/969#discussion_r152021426
 
 

 ##########
 File path: modules/api/src/main/java/org/apache/fluo/api/client/SnapshotBase.java
 ##########
 @@ -165,4 +167,22 @@
    * @return transactions start timestamp allocated from Oracle.
    */
   long getStartTimestamp();
+
+  default CompletableFuture<String> getsAsync(String row, Column column) {
+    return CompletableFuture.supplyAsync(() -> gets(row, column));
+  }
+
+  default CompletableFuture<String> getsAsync(String row, Column column, String defaultValue)
{
+    return CompletableFuture.supplyAsync(() -> gets(row, column, defaultValue));
 
 Review comment:
   Did you see my comment on the issue about supplyAsync?  These request will be put on a
JVM wide thread pool and these request do I/O.  So they may block other unrelated work in
the JVM, but not completely sure.  I will try to look into this some more.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message