fluo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] keith-turner commented on a change in pull request #999: Create 'fluo remove' command #991
Date Thu, 01 Jan 1970 00:00:00 GMT
keith-turner commented on a change in pull request #999: Create 'fluo remove' command #991
URL: https://github.com/apache/fluo/pull/999#discussion_r161251692
 
 

 ##########
 File path: modules/api/src/main/java/org/apache/fluo/api/client/FluoAdmin.java
 ##########
 @@ -119,6 +119,15 @@ public TableExistsException() {
   void initialize(InitializationOptions opts)
       throws AlreadyInitializedException, TableExistsException;
 
+  /**
+   * Removes Fluo application, Accumulo table and shared configuration in Zookeeper. Shared
configuration
+   * consists of all properties except those with
+   * {@value org.apache.fluo.api.config.FluoConfiguration#CONNECTION_PREFIX} prefix.
+   * 
+   * @since 1.2.0
+   */
+  void remove();
 
 Review comment:
   It would be really nice to have an integration test for this new API call.  The new test
could do the following.  
    * Add some data.  Remove the app.  Create an app with same name. Verify no data.  Add
some data.  Verify data.
    * Try to remove a running app.
   
   This test may be tricky to write because a lot of the current test code assumes a single
app.  I would be happy to write the test or provide guidance on writing the test, just let
me know.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message