fluo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] kpm1985 commented on issue #1005: FLUO-991 Format Source
Date Thu, 01 Jan 1970 00:00:00 GMT
kpm1985 commented on issue #1005: FLUO-991 Format Source
URL: https://github.com/apache/fluo/pull/1005#issuecomment-358753063
 
 
   I'm to blame.
   
   I'm really sorry I thought it was trivial like a typo and every time I ran
   mvn verify for my patch I'm working on that format correction kept showing
   on my diff.
   
   Again, seriously sorry just thought it was trivial
   
   
   
   On Jan 18, 2018 11:00 AM, "Keith Turner" <notifications@github.com> wrote:
   
   > It kind of raises the question, though: how much scrutiny needs to be
   > reviewed before committing automatic formatting changes performed by our
   > preexisting build tooling?
   >
   > RTC is the currently agreed upon method of making changes with no defined
   > exceptions. If an exception is to be made, I think its best to discuss it
   > beforehand. If anyone can decide to make exceptions to RTC when they see
   > fit, then the project is effectively CTR.
   >
   > ?
   > You are receiving this because you modified the open/close state.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/fluo/pull/1005#issuecomment-358747489>, or mute
   > the thread
   > <https://github.com/notifications/unsubscribe-auth/Acg-LKXM81HpVZPDm_eyjjW8n25qfQe6ks5tL5TegaJpZM4RifcA>
   > .
   >
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message