fluo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] jkosh44 commented on a change in pull request #1012: some small fixes for #1001
Date Thu, 01 Jan 1970 00:00:00 GMT
jkosh44 commented on a change in pull request #1012: some small fixes for #1001
URL: https://github.com/apache/fluo/pull/1012#discussion_r165145116
 
 

 ##########
 File path: modules/core/src/main/java/org/apache/fluo/core/impl/TransactionImpl.java
 ##########
 @@ -119,7 +119,7 @@ private static boolean isReadLock(Bytes val) {
     return val == RLOCK_VAL;
   }
 
-  private enum TxStatus {
+  private static enum TxStatus {
 
 Review comment:
   I wanted to keep doing small refactoring, without changing functionality, and pushing the
code to see how travis would behave differently. That was one of those refactorings. I'm pretty
sure inner enums are static by default so the static keyword was redundant.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message