fluo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] kpm1985 commented on a change in pull request #1035: Fluo 1000
Date Fri, 01 Jun 2018 00:52:06 GMT
kpm1985 commented on a change in pull request #1035: Fluo 1000
URL: https://github.com/apache/fluo/pull/1035#discussion_r192228970
 
 

 ##########
 File path: modules/core/src/main/java/org/apache/fluo/core/oracle/OracleServer.java
 ##########
 @@ -412,17 +418,23 @@ public void takeLeadership(CuratorFramework curatorFramework) throws
Exception {
       synchronized (this) {
         byte[] d = curatorFramework.getData().forPath(maxTsPath);
         currentTs = maxTs = LongUtil.fromByteArray(d);
+
+        isLeader = true;
       }
 
       gcTsTracker = new GcTimestampTracker();
       gcTsTracker.start();
 
-      isLeader = true;
-
       while (started) {
         // if leadership is lost, then curator will interrupt the thread that called this
method
         Thread.sleep(100);
       }
+    } catch (IllegalStateException e) {
 
 Review comment:
   Would merging that and having the changes "percolate" here (not intended as a bad joke
but hey) resolve this (even hypothetically?). If so I can try to help them out over there
to make it happen faster if that is desirable.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message