fluo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] ctubbsii commented on a change in pull request #149: Fluo recipes updates
Date Tue, 28 Aug 2018 21:56:59 GMT
ctubbsii commented on a change in pull request #149: Fluo recipes updates
URL: https://github.com/apache/fluo-recipes/pull/149#discussion_r213485569
 
 

 ##########
 File path: modules/test/src/main/java/org/apache/fluo/recipes/test/AccumuloExportITBase.java
 ##########
 @@ -39,7 +39,8 @@
 /**
  * This class is intended to be extended by classes testing exporting from Fluo to Accumulo.
Using
  * MiniFluo by itself is easy. However, using MiniAccumulo and MiniFluo together involves
writing a
- * lot of boiler plate code. Thats why this class exists, its a place to put that boiler
plate code.
+ * lot of boiler plate code. That's why this class exists, its a place to put that boiler
plate
 
 Review comment:
   boilerplate is one word. There's an opportunity to clean that up here also, which would
probably keep "code" on the same line.
   
   Also, "exists, its a place" should be replaced with "exists: it's a place"

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message