fluo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] busbey commented on a change in pull request #197: When using ACCUMULO_REPO, build with the appropriate Hadoop profile.
Date Thu, 20 Sep 2018 17:39:12 GMT
busbey commented on a change in pull request #197: When using ACCUMULO_REPO, build with the
appropriate Hadoop profile.
URL: https://github.com/apache/fluo-uno/pull/197#discussion_r219255153
 
 

 ##########
 File path: bin/impl/fetch.sh
 ##########
 @@ -59,10 +59,14 @@ function fetch_accumulo() {
   fi
 
   if [[ -n "$ACCUMULO_REPO" ]]; then
+    declare -a maven_args=(-DskipTests -DskipFormat)
+    if [[ "${HADOOP_VERSION}" = 3.* ]]; then
+      maven_args=("${maven_args[@]}" '-Dhadoop.profile=3')
 
 Review comment:
   I agree it won't hurt anything to define the variable and not have it used in the Accumulo
2 builds. I'm fine for being precise though, just let me know if you want to see an update.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message