fluo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] keith-turner commented on a change in pull request #197: When using ACCUMULO_REPO, build with the appropriate Hadoop profile.
Date Thu, 20 Sep 2018 19:08:50 GMT
keith-turner commented on a change in pull request #197: When using ACCUMULO_REPO, build with
the appropriate Hadoop profile.
URL: https://github.com/apache/fluo-uno/pull/197#discussion_r219283752
 
 

 ##########
 File path: bin/impl/fetch.sh
 ##########
 @@ -59,10 +59,14 @@ function fetch_accumulo() {
   fi
 
   if [[ -n "$ACCUMULO_REPO" ]]; then
+    declare -a maven_args=(-DskipTests -DskipFormat)
+    if [[ "${HADOOP_VERSION}" = 3.* ]]; then
+      maven_args=("${maven_args[@]}" '-Dhadoop.profile=3')
 
 Review comment:
   I think its fine.  Looking at these changes made me think it would be nice if Uno failed
fast  if trying to run Accumulo 1.x with Hadoop 3 when not building Accumulo.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message