fluo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] DogukanKundum commented on a change in pull request #5: clean code and safely inspect fix.
Date Sat, 02 Mar 2019 06:07:52 GMT
DogukanKundum commented on a change in pull request #5: clean code and safely inspect fix.
URL: https://github.com/apache/fluo-examples/pull/5#discussion_r261814601
 
 

 ##########
 File path: stresso/src/main/java/stresso/trie/Constants.java
 ##########
 @@ -18,15 +18,15 @@
 import org.apache.fluo.recipes.core.types.TypeLayer;
 
 /**
- *
+ *  global constant for fluo-example projects
  */
 public class Constants {
 
-  public static final TypeLayer TYPEL = new TypeLayer(new StringEncoder());
+    public static final TypeLayer TYPEL = new TypeLayer(new StringEncoder());
 
-  public static final Column COUNT_SEEN_COL = new Column("count", "seen");
-  public static final Column COUNT_WAIT_COL = new Column("count", "wait");
+    public static final Column COUNT_SEEN_COL = new Column("count", "seen");
 
 Review comment:
   my formatter different yours. this line code false at Constants.class. i’ll delete. sorry.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message