fluo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fluo-examples] ctubbsii commented on a change in pull request #8: Initial PageLoader Test ClassInitial test for the PageLoader class that covers null and empty checks
Date Fri, 15 Mar 2019 15:10:39 GMT
ctubbsii commented on a change in pull request #8: Initial PageLoader Test ClassInitial test
for the PageLoader class that covers null and empty checks
URL: https://github.com/apache/fluo-examples/pull/8#discussion_r266023320
 
 

 ##########
 File path: webindex/modules/data/src/test/java/webindex/data/fluo/PageLoaderTest.java
 ##########
 @@ -0,0 +1,63 @@
+package webindex.data.fluo;
+
+import java.net.MalformedURLException;
+
+import org.junit.Assert;
+import org.junit.Test;
+
+import webindex.core.models.Page;
+import webindex.core.models.URL;
+
+@SuppressWarnings("unused")
 
 Review comment:
   There's no reason to suppress this warning, since this is easily avoidable. For example,
replace:
   ```java
   Page p = null;
   PageLoader loader = PageLoader.updatePage(p);
   ```
   
   with:
   
   ```java
   PageLoader loader = PageLoader.updatePage((Page) null);
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message