fluo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fluo-examples] kpm1985 edited a comment on issue #8: Initial PageLoader Test ClassInitial test for the PageLoader class that covers null and empty checks
Date Sat, 16 Mar 2019 23:38:50 GMT
kpm1985 edited a comment on issue #8: Initial PageLoader Test ClassInitial test for the PageLoader
class that covers null and empty checks
URL: https://github.com/apache/fluo-examples/pull/8#issuecomment-473458259
 
 
    I wrote the test because I noticed load(Tx, Ctx) doesn't check for null args. The deletePage(URL
url) requires url not be null but doesn't care if its a url representing "", ie empty or blank.
The updatePage(Page page) method requires the url is not "" or blank/empty but doesn't care
if it gets a null page (leading to NPE).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message