fluo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fluo-examples] kpm1985 commented on issue #8: Initial PageLoader Test ClassInitial test for the PageLoader class that covers null and empty checks
Date Thu, 04 Apr 2019 21:43:00 GMT
kpm1985 commented on issue #8: Initial PageLoader Test ClassInitial test for the PageLoader
class that covers null and empty checks
URL: https://github.com/apache/fluo-examples/pull/8#issuecomment-480074577
 
 
   @keith-turner The two tests that are failing are testUpdatePageWithNullPage and testLoadWithNullTxCtx.

   The first failing test comes from here https://github.com/apache/fluo-examples/blob/47f1bb42969345b444f5c0e4c8c4a36ec93aab14/webindex/modules/data/src/main/java/webindex/data/fluo/PageLoader.java#L44-L50
   
   Where I think a simple Objects.requireNonNull(page) could do the trick.
   
   The second comes from here: https://github.com/apache/fluo-examples/blob/47f1bb42969345b444f5c0e4c8c4a36ec93aab14/webindex/modules/data/src/main/java/webindex/data/fluo/PageLoader.java#L60-L80
   
   And Objects.requireNonNull() could again do the trick.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message