fluo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fluo-muchos] ctubbsii commented on issue #270: Support Accumulo installs on Microsoft Azure
Date Thu, 08 Aug 2019 21:11:20 GMT
ctubbsii commented on issue #270: Support Accumulo installs on Microsoft Azure
URL: https://github.com/apache/fluo-muchos/pull/270#issuecomment-519688977
 
 
   Hi @srajtiwari . This is quite a large pull request, and I think it's going to take a bit
of time to review. In future, it would probably help to contribute smaller, more narrowly
scoped contributions. You have 6 different bullet points that this pull request accomplishes.
I think that those probably could have probably been 6 different pull requests.
   
   Also, I noticed that there's some binary files in here. Can you explain what those are?
We probably aren't going to be able to accept the binary files in the pull request, since
binaries are not "open source" by any standard definition.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message