fluo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fluo-muchos] keith-turner commented on a change in pull request #270: Support Accumulo installs on Microsoft Azure
Date Tue, 13 Aug 2019 15:15:18 GMT
keith-turner commented on a change in pull request #270: Support Accumulo installs on Microsoft
Azure
URL: https://github.com/apache/fluo-muchos/pull/270#discussion_r313456337
 
 

 ##########
 File path: ansible/roles/azure/tasks/create_vmss.yml
 ##########
 @@ -0,0 +1,238 @@
+---
+
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#    http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
 
 Review comment:
   Ok.  All of the other ansible code is meant to be copied to the cluster and used to provision
it.  This one file is very different.  It would be nice to make that difference readily apparent
to anyone spelunking in the Muchos source code.  A comment would accomplish this or could
put the file in a different directory tree like `$MUCHOS_HOME/ansible-client`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message