fluo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fluo] jkosh44 commented on a change in pull request #1087: Add Oracle count functionality
Date Tue, 03 Mar 2020 01:36:06 GMT
jkosh44 commented on a change in pull request #1087: Add Oracle count functionality
URL: https://github.com/apache/fluo/pull/1087#discussion_r386752709
 
 

 ##########
 File path: modules/command/src/main/java/org/apache/fluo/command/FluoList.java
 ##########
 @@ -91,7 +91,8 @@ private void listApp(FluoConfiguration config, String path) {
         state = "RUNNING";
       }
       int numWorkers = admin.numWorkers();
-      System.out.format("%-15s %-11s %4d\n", path, state, numWorkers);
+      int numOracles = admin.numOracles();
+      System.out.format("%-15s %-11s %4d %13d\n", path, state, numWorkers, numOracles);
 
 Review comment:
   I've attached some screenshots so you can see how the spacing looks.
   
   As a note, if you call `fluo list` too soon after starting or stopping an oracle then the
oracle count may not have been updated yet (you can see some examples of this in my screenshots).
I see the same behavior with workers so I think it should be fine. 
   ![Screenshot from 2020-03-02 20-33-10](https://user-images.githubusercontent.com/10800303/75734230-61f54c80-5cc5-11ea-8ca7-d4b9c4015436.png)
   ![Screenshot from 2020-03-02 20-33-59](https://user-images.githubusercontent.com/10800303/75734233-628de300-5cc5-11ea-85db-6e930372faa8.png)
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message