fluo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fluo-muchos] arvindshmicrosoft commented on a change in pull request #327: Configure Job history server
Date Thu, 05 Mar 2020 05:31:21 GMT
arvindshmicrosoft commented on a change in pull request #327: Configure Job history server
URL: https://github.com/apache/fluo-muchos/pull/327#discussion_r388085297
 
 

 ##########
 File path: ansible/roles/zookeeper/tasks/start-zookeeper.yml
 ##########
 @@ -19,7 +19,13 @@
   file: path={{ default_data_dirs[0] }}/zookeeper state=directory
 - name: "ensure myid file is set"
   template: src=roles/zookeeper/templates/myid dest={{ default_data_dirs[0] }}/zookeeper/myid
+- name: Check if Zookeeper is running
 
 Review comment:
   I don't recall any issues related to idempotency of the subsequent "start zookeeper" task,
so I'm curious why we need to add this. Could you clarify?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message