fluo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fluo-muchos] karthick-rn commented on a change in pull request #327: Configure Job history server
Date Thu, 05 Mar 2020 11:05:16 GMT
karthick-rn commented on a change in pull request #327: Configure Job history server
URL: https://github.com/apache/fluo-muchos/pull/327#discussion_r388224180
 
 

 ##########
 File path: ansible/roles/zookeeper/tasks/start-zookeeper.yml
 ##########
 @@ -19,7 +19,13 @@
   file: path={{ default_data_dirs[0] }}/zookeeper state=directory
 - name: "ensure myid file is set"
   template: src=roles/zookeeper/templates/myid dest={{ default_data_dirs[0] }}/zookeeper/myid
+- name: Check if Zookeeper is running
 
 Review comment:
   Sure. I have added the check because in ZK 3.5.6 the start script throws a non-zero return
code when ZK was found already running which fails the task. It is slightly different in ZK
3.4.14 where the script was returning "0" return code in that situation. This check works
for both versions of ZK & also the approach in ZK 3.5.6 is in-line with other start scripts
in Hadoop. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message