fluo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fluo-muchos] ivakegg commented on a change in pull request #331: WIP - #254
Date Tue, 10 Mar 2020 16:02:33 GMT
ivakegg commented on a change in pull request #331: WIP - #254
URL: https://github.com/apache/fluo-muchos/pull/331#discussion_r390417866
 
 

 ##########
 File path: ansible/roles/elasticsearch/tasks/main.yml
 ##########
 @@ -0,0 +1,71 @@
+---
+#
+# Installing Elasticsearch
+#
+
+# Add the Elasticsearch yum repo. 
+
+- name: "download elasticsearch rpm"
+  get_url: 
+  args:
+    url: https://artifacts.elastic.co/downloads/elasticsearch/{{ elasticsearch_rpm }}
+    dest: /tmp/{{ elasticsearch_rpm }}
+    force: no
+  
+
+ #Install elasticsearch    
+
+- name: "ensure elasticsearch is installed"
+  become: true
+  yum: name=/tmp/{{ elasticsearch_rpm }} state=present
 
 Review comment:
   is stating that the directory exists sufficient to say it is installed?  Can we validate
any of the contents therein?  If this is the standard practice then feel free to ignore this
comment.  Otherwise this applies to the installation files as well.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message