freemarker-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel Dekany <ddek...@apache.org>
Subject Re: SpringBoot, DataModelParser and Travis CI
Date Fri, 28 Apr 2017 16:17:36 GMT
Friday, April 28, 2017, 3:38:25 PM, Pradeep Murugesan wrote:

> Hi Daniel,
>
>
>    I have added the Dropwizard and removed the existing Fallwizard
> dependency. Didn't change the much of the existing files .
>
>
> https://github.com/pradeepmurugesan/incubator-freemarker-online-tester/tree/dropwizard
>
>
> yet to update the read me and other references to fallwizard.
>
>
> I have a question, we are tied tied to Java 7 in this project via
> the gradle 1.7. I tried upgrading the gradle wrapper version but
> looks likes it needs some effort. So I couldn't use the latest version of Dropwizard
and Spring.
>
> I feel that we need to move to Java 8 so that can use the latest
> libararies. Let me know your thoughts.

Sure, we should use the latest from everything, especially from Java.
I don't think there will be any notable obstacles there.

>
>
> Pradeep.
>
>
>
>
> ________________________________
> From: Daniel Dekany <ddekany@apache.org>
> Sent: Thursday, April 27, 2017 6:08:46 PM
> To: Pradeep Murugesan
> Subject: Re: SpringBoot, DataModelParser and Travis CI
>
> Thursday, April 27, 2017, 12:58:51 PM, Pradeep Murugesan wrote:
>
>> Hi Daniel,
>>
>>
>>      Yes we are right now using some Autowired annotations from
>> Spring. I tried to retain the same so that we can bring the
>> application without much changes. The changes I am planning is
>>
>>
>> 1. remove Fallwizard
>>
>> 2. use Dropwizard to build jar and boot the application.
>>
>> 3. Integrate with Spring to retain the autowired.
>>
>>
>> Let me know if we need to remove Spring completely and use normal
>> way to create instances without the Autowired.
>
> I have never worked with Dropwizard, I haven't done any serious
> research either, so I don't know what the best approach is. But some
> thoughts:
>
> - Does an IoC/DI framework have any real benefit in this small
>   application? In Dropwizard, aren't you simply supposed to instantiate
>   the singleton beans in the Application class, together the javax.ws.rs
>   resources, and pass the dependencies to the beans as constructor
>   paramteres, or something like that?
>
> - If we want an IoC/DI framework, I believe using Guice is more common
>   with Dropwizard. Or just was? I'm not sure. Anyway, in case there's
>   some problem with the Spring IoC integration, there's also Guice
>   integration.
>
>> Pradeep.
>>
>> ________________________________
>> From: Daniel Dekany <ddekany@apache.org>
>> Sent: Sunday, April 23, 2017 11:40:07 AM
>> To: Pradeep Murugesan
>> Subject: Re: SpringBoot, DataModelParser and Travis CI
>>
>> Saturday, April 22, 2017, 9:47:36 PM, Pradeep Murugesan wrote:
>>
>>> I was playing with spring boot, looks like we need some major
>>> refactoring if spring boot is used. As the current version of the
>>> spring dependencies and the one that spring boot depends on vary
>>> much and leads into a lot of issues.
>>
>> (I would think that if you take the application specific parts only,
>> they can be pretty much copy-pasted into to a typical JSON-based
>> microservice Spring Boot application skeleton. Porting some tests can
>> be a bit trickier maybe. But for a mini application like this, I'm not
>> leaning towards Spring Boot at all, so not using it fine with me.)
>>
>>> I have started to look into the solutions that use Drop wizard and
>>> Spring integrations. May be this week would be able to resolve it I guess.
>>
>> If you are going to use Dropwizard, do we need Spring integration at
>> all? What Spring features do we actually need for this simple
>> application?
>>
>>> Pradeep.
>>>
>>> ________________________________
>>> From: Daniel Dekany <ddekany@apache.org>
>>> Sent: Saturday, April 22, 2017 2:55:38 AM
>>> To: Pradeep Murugesan
>>> Subject: Re: SpringBoot, DataModelParser and Travis CI
>>>
>>> Any idea when (and if) can you deal with replacing Fallwizard?
>>>
>>>
>>> Sunday, April 9, 2017, 10:38:37 AM, Pradeep Murugesan wrote:
>>>
>>>> Hi,
>>>>
>>>>
>>>>    Moving this to a separate thread.
>>>>
>>>>
>>>> So as the packages are renamed I will start with
>>>>
>>>>
>>>> 1. Removing the Fallwizard . (try out SpringBoot)
>>>>
>>>> 2. Optimising the DataModel
>>>>
>>>>
>>>>
>>>> Also I have asked a CI question in the previous email which got
>>>> lost. Posting the same in this email.
>>>>
>>>>
>>>>   1.  Do we need to configure travis CI for the online tester ?
>>>>
>>>>
>>>> Pradeep.
>>>>
>>>>
>>>> ________________________________
>>>> From: Daniel Dekany <ddekany@apache.org>
>>>> Sent: Friday, April 7, 2017 6:29 PM
>>>> To: Woonsan Ko
>>>> Subject: Re: Anyone volunteers for online-tester legal cleanup and other
refactorings?
>>>>
>>>> Friday, April 7, 2017, 5:59:21 PM, Woonsan Ko wrote:
>>>>
>>>>> On Fri, Apr 7, 2017 at 10:21 AM, Pradeep Murugesan
>>>>> <pradeepmurugesan@outlook.com> wrote:
>>>>>> Hi,
>>>>>>
>>>>>> After that:
>>>>>>
>>>>>> - Get rid of the old Fallwizard dependency, as that version isn't
>>>>>>   available in well known repos. Certainly we should just use pure
>>>>>>   Dropwizard (or any other light weight "micro service" framework
you
>>>>>>
>>>>>>   feel like using).
>>>>>>
>>>>>> Do you think we can give a short at Spring boot to replace Fallwizard
?
>>>>>
>>>>> Spring boot sounds like a good idea to me.
>>>>
>>>> Assuming it doesn't have significant memory overhead compared to
>>>> Dropwizard, it's fine.
>>>>
>>>>> By the way, regarding the data model parsing, I'm just wondering if we
>>>>> can simplify the parsing code (DataModelParser.java) by accepting only
>>>>> a JSON string like the following example:
>>>>>
>>>>> {
>>>>>   someString: "Some value",
>>>>>   someNumber: 3.14,
>>>>>   someBoolean: true
>>>>>   someDatetime: "2014-02-28T18:50Z",
>>>>>   someList: ["JSON", "syntax", 1, 2, 3 ],
>>>>>   someMap: { "JSON syntax": true, "nestedList": [1, 2, 3] }
>>>>>   someXML: "<example x='1'>text</example>"
>>>>> }
>>>>>
>>>>> Jackson support ALLOW_UNQUOTED_FIELD_NAMES option and good type
>>>>> handling of values...
>>>>
>>>> The question remains if what should we do with date/time values (which
>>>> JSON doesn't have), XML values, as there's no JSON syntax for them.
>>>>
>>>> Also JSON is less convenient, as it doesn't support multi-line strings
>>>> and XML as we do, and that's especially handy for XML. You don't even
>>>> have to quote XML with the current syntax, which makes copy-pasting
>>>> snippets much easier. Copy-pasting is a design goal here.
>>>>
>>>> BTW, right now we have the issue that you can't use date/time or XML
>>>> inside lists and maps, exactly because those use JSON syntax. So I'm
>>>> rather on the side of moving away from JSON. It's too simplistic by
>>>> design, and we have no power to extend it. And writing out own parsers
>>>> is easy, so, why not...
>>>>
>>>>> Just my two cents,
>>>>>
>>>>> Woonsan
>>>>>
>>>>>> Also should we think about using Travis CI for continuous integration
or you have any other ideas ?
>>>>>>
>>>>>> Pradeep.
>>>>>> ________________________________
>>>>>> From: Daniel Dekany <ddekany@apache.org>
>>>>>> Sent: Saturday, April 1, 2017 10:09 PM
>>>>>> To: dev@freemarker.incubator.apache.org
>>>>>> Subject: Anyone volunteers for online-tester legal cleanup and other
refactorings?
>>>>>>
>>>>>> We have just received the source code of
>>>>>> http://freemarker-online.kenshoo.com/ from Kenshoo, as a contribution
>>>> [https://camo.githubusercontent.com/a6677b08c955af8400f44c6298f40e7d19cc5b2d/68747470733a2f2f73332e616d617a6f6e6177732e636f6d2f6769746875622f726962626f6e732f666f726b6d655f72696768745f677261795f3664366436642e706e67]<http://freemarker-online.kenshoo.com/>
>>>>
>>>> Online FreeMarker Template
>>>> Tester<http://freemarker-online.kenshoo.com/>
>>>> freemarker-online.kenshoo.com
>>>> Note: This syntax is specific to this online service; normally, you
>>>> just have Java objects as data-model.
>>>>
>>>>
>>>>
>>>>>> to the FreeMarker project. Here's the Git repo:
>>>>>>
>>>>>> https://git-wip-us.apache.org/repos/asf?p=incubator-freemarker-online-tester.git
>>>>>> https://github.com/apache/incubator-freemarker-online-tester
>>>>>>
>>>>>> Anyone wants to take care of some (or all) of these tasks:
>>>>>>
>>>>>> The first thing to do is the legal cleanup:
>>>>>> - Change license headers (such as it can't contain "Copyright 2014
Kenshoo.com")
>>>>>> - Change the package from com.kenshoo.freemarker to
>>>>>>   org.apache.freemarker.onlinetester (or something like that)
>>>>>> - Update LICENSE (and NOTICES if needed) with any extra intellectual
>>>>>>   property related information needed.
>>>>>>
>>>>>> After that:
>>>>>> - Get rid of the old Fallwizard dependency, as that version isn't
>>>>>>   available in well known repos. Certainly we should just use pure
>>>>>>   Dropwizard (or any other light weight "micro service" framework
you
>>>>>>   feel like using).
>>>>>>
>>>>>> And finally we should continue pushing
>>>>>> https://issues.apache.org/jira/browse/INFRA-13246 "Create a demo
VM
>>>> [INFRA-13246] Create a demo VM for the Freemarker project
>>>> ...<https://issues.apache.org/jira/browse/INFRA-13246>
>>>> issues.apache.org
>>>> The Freemarker team (incubating) would like to promote their
>>>> project more. The site http://freemarker-online.kenshoo.com/
>>>> provides a way to test Freemarker code online.
>>>>
>>>>
>>>>
>>>>>> [INFRA-13246] Create a demo VM for the Freemarker project ...<https://issues.apache.org/jira/browse/INFRA-13246>
>>>> [INFRA-13246] Create a demo VM for the Freemarker project
>>>> ...<https://issues.apache.org/jira/browse/INFRA-13246>
>>>> issues.apache.org
>>>> The Freemarker team (incubating) would like to promote their
>>>> project more. The site http://freemarker-online.kenshoo.com/
>>>> provides a way to test Freemarker code online.
>>>>
>>>>
>>>>
>>>>>> issues.apache.org
>>>>>> The Freemarker team (incubating) would like to promote their project
more. The site http://freemarker-online.kenshoo.com/ provides a way to test Freemarker code
online.
>>>> [https://camo.githubusercontent.com/a6677b08c955af8400f44c6298f40e7d19cc5b2d/68747470733a2f2f73332e616d617a6f6e6177732e636f6d2f6769746875622f726962626f6e732f666f726b6d655f72696768745f677261795f3664366436642e706e67]<http://freemarker-online.kenshoo.com/>
>>>>
>>>> Online FreeMarker Template
>>>> Tester<http://freemarker-online.kenshoo.com/>
>>>> freemarker-online.kenshoo.com
>>>> Note: This syntax is specific to this online service; normally, you
>>>> just have Java objects as data-model.
>>>>
>>>>
>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> for the Freemarker project".
>>>>>>
>>>>>> --
>>>>>> Thanks,
>>>>>>  Daniel Dekany
>>>>>>
>>>>>
>>>>
>>>> --
>>>> Thanks,
>>>>  Daniel Dekany
>>>>
>>>
>>> --
>>> Thanks,
>>>  Daniel Dekany
>>>
>>
>> --
>> Thanks,
>>  Daniel Dekany
>>
>
> --
> Thanks,
>  Daniel Dekany
>

-- 
Thanks,
 Daniel Dekany


Mime
View raw message