freemarker-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel Dekany <daniel.dek...@gmail.com>
Subject Re: Contributing to FREEMARKER-35: JSR 310 support for java8 java.time.temporal DateTimeFormatter
Date Sun, 29 Mar 2020 22:12:24 GMT
Hi Teun,

Did you submit the CLI?

On Wed, Feb 26, 2020 at 4:17 PM Teun <teun@betterbe.com> wrote:

> Fixed the two random small things.
> I'll try to submit the CLA request.
>
> Regards, Teun
>
> > On 2020-02-24, at 22:04, Daniel Dekany <daniel.dekany@gmail.com> wrote:
> >
> > OK, great!
> >
> > Two random small things that I happened to spot (but eventually I will go
> > through all this properly):
> >
> >   - Instead of things like YEARMONTH_FORMAT_KEY_CAMEL_CASE,
> >   "yearmonth_format", and "year_month_format", let's use the more natural
> >   YEAR_MONTH_FORMAT, "year_month_format", and "yearMonthFormat". Same
> for the
> >   other temporal types as well. I assume you just tried to be consistent
> with
> >   "datetime", but that's actually a mistake (that's the SQL-ish name of
> the
> >   type, that somehow get into releases unfortunately... maybe we should
> add
> >   date_time etc. as an alias).
> >   - String getTemporalFormat(Temporal temporal): Maybe fine for
> >   convenience, but the basic overload should be  String
> >   getTemporalFormat(Class<? extends Temporal> temporalClass), as this
> >   function doesn't really care about the instance.
> >
> >
> > When you have the CLA (and are yo sure that your employee can't claim
> this
> > or such), we can merge into the FREEMARKER-35 branch. When it's finished,
> > which also means the me or some others here went through it, polished it,
> > etc., then it will be merged into the 2.3-gae branch.
> >
> > Thanks!
>
>

-- 
Best regards,
Daniel Dekany

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message