gearpump-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From manuzhang <...@git.apache.org>
Subject [GitHub] incubator-gearpump pull request #134: [GEARPUMP-265] remove AppMasterRuntime...
Date Mon, 23 Jan 2017 02:22:05 GMT
Github user manuzhang commented on a diff in the pull request:

    https://github.com/apache/incubator-gearpump/pull/134#discussion_r97244536
  
    --- Diff: core/src/main/scala/org/apache/gearpump/cluster/ClusterMessage.scala ---
    @@ -155,9 +158,13 @@ object MasterToClient {
     
       /** Return the last error of this streaming application job */
       case class LastFailure(time: TimeStamp, error: String)
    -}
     
    -trait AppMasterRegisterData
    +  sealed trait ApplicationResult
    +
    +  case class ApplicationFinished(appId: Int) extends ApplicationResult
    --- End diff --
    
    What does `Finished` mean ? Do you want to say `Succeeded` ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message