gearpump-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From manuzhang <...@git.apache.org>
Subject [GitHub] incubator-gearpump pull request #134: [GEARPUMP-252] return application stat...
Date Mon, 23 Jan 2017 08:20:29 GMT
Github user manuzhang commented on a diff in the pull request:

    https://github.com/apache/incubator-gearpump/pull/134#discussion_r97268898
  
    --- Diff: core/src/main/scala/org/apache/gearpump/cluster/ClusterMessage.scala ---
    @@ -155,26 +158,20 @@ object MasterToClient {
     
       /** Return the last error of this streaming application job */
       case class LastFailure(time: TimeStamp, error: String)
    -}
     
    -trait AppMasterRegisterData
    +  sealed trait ApplicationResult
    --- End diff --
    
    how is `ApplicationResult` mapped to `ApplicationStatus` ? If both of them are internal
interfaces, can we just return `ApplicationStatus` to the client ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message