gearpump-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From manuzhang <...@git.apache.org>
Subject [GitHub] incubator-gearpump pull request #223: [GEARPUMP-349] Optimize Graph topologi...
Date Thu, 14 Sep 2017 12:15:40 GMT
Github user manuzhang commented on a diff in the pull request:

    https://github.com/apache/incubator-gearpump/pull/223#discussion_r138875439
  
    --- Diff: core/src/main/scala/org/apache/gearpump/util/Graph.scala ---
    @@ -28,6 +29,8 @@ class Graph[N, E](vertexList: List[N], edgeList: List[(N, E, N)]) extends
Serial
     
       private val _vertices = mutable.Set.empty[N]
       private val _edges = mutable.Set.empty[(N, E, N)]
    +  private val _outEdges = mutable.Map.empty[N, List[(N, E, N)]]
    --- End diff --
    
    Will `Set` perform better than `List` here ?


---

Mime
View raw message