gearpump-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From manuzhang <...@git.apache.org>
Subject [GitHub] incubator-gearpump pull request #223: [GEARPUMP-349] Optimize Graph topologi...
Date Fri, 15 Sep 2017 01:56:35 GMT
Github user manuzhang commented on a diff in the pull request:

    https://github.com/apache/incubator-gearpump/pull/223#discussion_r139049560
  
    --- Diff: core/src/main/scala/org/apache/gearpump/util/Graph.scala ---
    @@ -156,64 +155,64 @@ class Graph[N, E](vertexList: List[N], edgeList: List[(N, E, N)])
extends Serial
        * Current Graph is not changed.
        */
       def mapVertex[NewNode](fun: N => NewNode): Graph[NewNode, E] = {
    -    val vertexes = vertices.map(node => (node, fun(node)))
    +    val newVertexes = getVertices.map(node => (node, fun(node)))
     
    -    val vertexMap: Map[N, NewNode] = vertexes.toMap
    +    val vertexMap: Map[N, NewNode] = newVertexes.toMap
     
    -    val newEdges = edges.map { edge =>
    +    val newEdges = getEdges.map { edge =>
           (vertexMap(edge._1), edge._2, vertexMap(edge._3))
         }
    -    new Graph(vertexes.map(_._2), newEdges)
    +    new Graph(newVertexes.map(_._2), newEdges)
    --- End diff --
    
    I believe the plural of Vertex is Vertices


---

Mime
View raw message