gearpump-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEARPUMP-369) "executor-num" is overridden by the default value for arg "executors"(1)
Date Thu, 05 Apr 2018 10:22:00 GMT

    [ https://issues.apache.org/jira/browse/GEARPUMP-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16426716#comment-16426716
] 

ASF GitHub Bot commented on GEARPUMP-369:
-----------------------------------------

Github user codecov-io commented on the issue:

    https://github.com/apache/incubator-gearpump/pull/242
  
    # [Codecov](https://codecov.io/gh/apache/incubator-gearpump/pull/242?src=pr&el=h1)
Report
    > Merging [#242](https://codecov.io/gh/apache/incubator-gearpump/pull/242?src=pr&el=desc)
into [master](https://codecov.io/gh/apache/incubator-gearpump/commit/8aac07b86d4b90e4f5118f3204610d3510f93b02?src=pr&el=desc)
will **increase** coverage by `0.09%`.
    > The diff coverage is `50%`.
    
    
    
    ```diff
    @@            Coverage Diff             @@
    ##           master     #242      +/-   ##
    ==========================================
    + Coverage   68.94%   69.03%   +0.09%     
    ==========================================
      Files         191      191              
      Lines        6128     6130       +2     
      Branches      542      540       -2     
    ==========================================
    + Hits         4225     4232       +7     
    + Misses       1903     1898       -5
    ```
    



> "executor-num" is overridden by the default value for arg "executors"(1) 
> -------------------------------------------------------------------------
>
>                 Key: GEARPUMP-369
>                 URL: https://issues.apache.org/jira/browse/GEARPUMP-369
>             Project: Apache Gearpump
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 0.8.4, 0.8.5
>            Reporter: Hashan Gayasri Udugahapattuwa
>            Priority: Minor
>
> org/apache/gearpump/cluster/main/AppSubmitter.scala:62
> System.setProperty(Constants.APPLICATION_EXECUTOR_NUMBER, config.getInt("executors").toString)
>  
> replaces the value set by system properties (gear.conf) by the default value(1) even
when no value is passed at as an argument. The expected behaviour is to only override the
value when a value is given explicitly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message