geronimo-scm mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rickmcgu...@apache.org
Subject svn commit: r686231 - /geronimo/javamail/trunk/geronimo-javamail_1.4/geronimo-javamail_1.4_provider/src/main/java/org/apache/geronimo/javamail/store/nntp/NNTPGroupFolder.java
Date Fri, 15 Aug 2008 14:24:20 GMT
Author: rickmcguire
Date: Fri Aug 15 07:24:20 2008
New Revision: 686231

URL: http://svn.apache.org/viewvc?rev=686231&view=rev
Log:
GERONIMO-4252 NNTP Transport provider does not correctly store message identifiers
Patch provided by David Graf


Modified:
    geronimo/javamail/trunk/geronimo-javamail_1.4/geronimo-javamail_1.4_provider/src/main/java/org/apache/geronimo/javamail/store/nntp/NNTPGroupFolder.java

Modified: geronimo/javamail/trunk/geronimo-javamail_1.4/geronimo-javamail_1.4_provider/src/main/java/org/apache/geronimo/javamail/store/nntp/NNTPGroupFolder.java
URL: http://svn.apache.org/viewvc/geronimo/javamail/trunk/geronimo-javamail_1.4/geronimo-javamail_1.4_provider/src/main/java/org/apache/geronimo/javamail/store/nntp/NNTPGroupFolder.java?rev=686231&r1=686230&r2=686231&view=diff
==============================================================================
--- geronimo/javamail/trunk/geronimo-javamail_1.4/geronimo-javamail_1.4_provider/src/main/java/org/apache/geronimo/javamail/store/nntp/NNTPGroupFolder.java
(original)
+++ geronimo/javamail/trunk/geronimo-javamail_1.4/geronimo-javamail_1.4_provider/src/main/java/org/apache/geronimo/javamail/store/nntp/NNTPGroupFolder.java
Fri Aug 15 07:24:20 2008
@@ -238,7 +238,9 @@
         int idStart = response.indexOf('<');
         int idEnd = response.indexOf('>');
 
-        message = new NNTPMessage(this, (NNTPStore) store, msgNum, response.substring(idStart
+ 1, idEnd));
+        // NB:  The "<" and ">" delimiters are required elements of the message id,
not just 
+        // delimiters for the sake of the command.  We need to keep these around 
+        message = new NNTPMessage(this, (NNTPStore) store, msgNum, response.substring(idStart,
idEnd + 1));
 
         // add this to the article cache.
         articles.put(key, message);



Mime
View raw message