From scm-return-47261-apmail-geronimo-scm-archive=geronimo.apache.org@geronimo.apache.org Tue Sep 6 08:49:38 2011 Return-Path: X-Original-To: apmail-geronimo-scm-archive@www.apache.org Delivered-To: apmail-geronimo-scm-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5D74D7A0D for ; Tue, 6 Sep 2011 08:49:38 +0000 (UTC) Received: (qmail 21386 invoked by uid 500); 6 Sep 2011 08:49:34 -0000 Delivered-To: apmail-geronimo-scm-archive@geronimo.apache.org Received: (qmail 21211 invoked by uid 500); 6 Sep 2011 08:49:12 -0000 Mailing-List: contact scm-help@geronimo.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@geronimo.apache.org List-Id: Delivered-To: mailing list scm@geronimo.apache.org Received: (qmail 21203 invoked by uid 99); 6 Sep 2011 08:49:09 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Sep 2011 08:49:09 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Sep 2011 08:49:08 +0000 Received: from eris.apache.org (localhost [127.0.0.1]) by eris.apache.org (Postfix) with ESMTP id E0FD523889BB; Tue, 6 Sep 2011 08:48:47 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1165565 - /geronimo/server/branches/2.2/plugins/connector/geronimo-connector/src/main/java/org/apache/geronimo/connector/outbound/ManagedConnectionFactoryWrapper.java Date: Tue, 06 Sep 2011 08:48:47 -0000 To: scm@geronimo.apache.org From: violalu@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20110906084847.E0FD523889BB@eris.apache.org> Author: violalu Date: Tue Sep 6 08:48:47 2011 New Revision: 1165565 URL: http://svn.apache.org/viewvc?rev=1165565&view=rev Log: GERONIMO-6146 fix classcast exception when creating oracle rac datasource, replace String with StringBuilder Modified: geronimo/server/branches/2.2/plugins/connector/geronimo-connector/src/main/java/org/apache/geronimo/connector/outbound/ManagedConnectionFactoryWrapper.java Modified: geronimo/server/branches/2.2/plugins/connector/geronimo-connector/src/main/java/org/apache/geronimo/connector/outbound/ManagedConnectionFactoryWrapper.java URL: http://svn.apache.org/viewvc/geronimo/server/branches/2.2/plugins/connector/geronimo-connector/src/main/java/org/apache/geronimo/connector/outbound/ManagedConnectionFactoryWrapper.java?rev=1165565&r1=1165564&r2=1165565&view=diff ============================================================================== --- geronimo/server/branches/2.2/plugins/connector/geronimo-connector/src/main/java/org/apache/geronimo/connector/outbound/ManagedConnectionFactoryWrapper.java (original) +++ geronimo/server/branches/2.2/plugins/connector/geronimo-connector/src/main/java/org/apache/geronimo/connector/outbound/ManagedConnectionFactoryWrapper.java Tue Sep 6 08:48:47 2011 @@ -193,12 +193,11 @@ public class ManagedConnectionFactoryWra if(value != null && value instanceof Properties){ Properties ps = (Properties) value; if (!ps.isEmpty()) { - String s = null; + StringBuilder s = new StringBuilder(); for (Object o : ps.keySet()) { String k = (String) o; String v = ps.getProperty(k); - s = k + "=" + v + ","; - log.debug("Setting " + k + "=" + value); + s = s.append(k).append("=").append(v).append(","); } delegate.setAttribute(name, s); log.debug("Setting " + name + " value " + s);