geronimo-xbean-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ivan <xhh...@gmail.com>
Subject Fwd: The change in xbean/trunk@1095593 brought some regressions to ejblite.
Date Tue, 03 May 2011 00:57:39 GMT
I am thinking that we should have a uniform style what the directory
structure is expected while invoking the callback methods, with slash suffix
or not.
--->
public boolean directoryDiscoveryRequired(String url) {
            return true;
        }
<---
>From the initial design, it looks that we should always expect a slash
suffix with directory
--->
public BundleResourceFinder(PackageAdmin packageAdmin, Bundle bundle, String
prefix, String suffix, ResourceDiscoveryFilter discoveryFilter) {
        this.packageAdmin = packageAdmin;
        this.bundle = bundle;
        this.prefix = addSlash(prefix.trim());
        ....
<---
I did not have a special favor for this, but need to keep the consistency.
Thoughts ?


---------- Forwarded message ----------
From: Shawn Jiang <genspring@gmail.com>
Date: 2011/5/2
Subject: Re: The change in xbean/trunk@1095593 brought some regressions to
ejblite.
To: Ivan <xhhsld@gmail.com>


In persistencethe finder can't find

s =" /WEB-INF/classes/"  because the string in manifestcp is
"/WEB-INF/classes"


org.apache.geronimo.persistence.builder.PersistenceUnitBuilder.initContext(...).new
ResourceDiscoveryFilter() {...}.directoryDiscoveryRequired(String){
                    return manifestcp.contains(s);

                }

On Mon, May 2, 2011 at 9:46 PM, Ivan <xhhsld@gmail.com> wrote:

> Hi, Shawn
>     I did not see there is an issue for the code changes,
>     --->
>     continueScanning = scanDirectory(callback, bundle,
> prefix.startsWith("/") ? name + prefix : name + "/" + prefix)
>     <---
>     It justs make sure the correct path is built, could you give any hit ?
> Thanks.
>
>
> 2011/5/2 Shawn Jiang <genspring@gmail.com>
>
>> Author: Haihong Xu <xuhaihong@apache.org>  2011-04-21 10:56:03
>> Committer: Haihong Xu <xuhaihong@apache.org>  2011-04-21 10:56:03
>> Parent: e6c32dd892f15927ea1ca1687c2ef5db039cc57b (use the original bundle
>> passed for resource lookup)
>> Child:  5de3a3e1b5a783a1913aacf4d53ad50e89a249ea (Pass the native bundle
>> instance for wired bundles calculation)
>> Branches: remotes/origin/trunk, trunk
>> Follows:
>> Precedes:
>>
>>     The elements in the bundle-classpath do not end with '/', need to add
>> the slash based on the value of prefix
>>
>>     git-svn-id:
>> https://svn.apache.org/repos/asf/geronimo/xbean/trunk@109559313f79535-47bb-0310-9956-ffa450edef68
>>
>>
>> Hi Ivan,
>>
>> The change above brought some regressions to  ejblite.
>>
>>
>> https://phoebe.apache.org:9443/jobs/artifacts/164/2098049/Geronimo_3_0_M2_Web_Profile_jetty_web_Test_Results/iteration-5.html
>>
>>
>> --
>> Shawn
>>
>
>
>
> --
> Ivan
>



-- 
Shawn



-- 
Ivan

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message