geronimo-xbean-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "JC (JIRA)" <j...@apache.org>
Subject [jira] [Created] (XBEAN-299) A condition that is always true.
Date Sat, 11 Feb 2017 17:40:41 GMT
JC created XBEAN-299:
------------------------

             Summary: A condition that is always true.
                 Key: XBEAN-299
                 URL: https://issues.apache.org/jira/browse/XBEAN-299
             Project: XBean
          Issue Type: Bug
            Reporter: JC
            Priority: Trivial


I've found the following code spell or typo in a recent github snapshot.

Path 1: xbean-blueprint/src/main/java/org/apache/xbean/blueprint/context/impl/NamedConstructorArgs.java

Path 2: xbean-spring/src/main/java/org/apache/xbean/spring/context/impl/NamedConstructorArgs.java

{code:java}
313         public boolean equals(Object object) {
314             if (!(object instanceof PropertyKey)) {
315                 return false;
316             }
317 
318             PropertyKey defaultProperty = (PropertyKey) object;
319             return name.equals(defaultProperty.name) && type.equals(type);
320         }
{code}

Could it be as follows? This might be a trivial issue but wanted to report just in case.

{code:java}
318             PropertyKey defaultProperty = (PropertyKey) object;
319             return name.equals(defaultProperty.name) && type.equals(defaultProperty.type);
320         }
{code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message