giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Arun Suresh (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GIRAPH-85) Simplify return expression in RPCCommunications::getRPCProxy
Date Tue, 15 Nov 2011 08:33:53 GMT

    [ https://issues.apache.org/jira/browse/GIRAPH-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13150305#comment-13150305
] 

Arun Suresh commented on GIRAPH-85:
-----------------------------------

Both the proxy objects look different though. But yes, we can create a final local CommunicationInterface<I,
V, E, M> proxy object. return that in the first case and in the second case pass it to
the run() method of the anonymous inner class inheriting from PrivilegedExceptionAction<CommunicationInterface<I,
V, E, M>> 
                
> Simplify return expression in RPCCommunications::getRPCProxy
> ------------------------------------------------------------
>
>                 Key: GIRAPH-85
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-85
>             Project: Giraph
>          Issue Type: Improvement
>            Reporter: Jakob Homan
>              Labels: newbie
>
> Twice in RPCCommunications::getRPCProxy a local variable, proxy, is created and immediately
returned.  We can simplify this to just return the value.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message