giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Claudio Martella (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GIRAPH-74) GIRAPH-36 missed a couple of liners when passing from Vertex to BasicVertex
Date Thu, 10 Nov 2011 22:49:51 GMT

    [ https://issues.apache.org/jira/browse/GIRAPH-74?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13148080#comment-13148080
] 

Claudio Martella commented on GIRAPH-74:
----------------------------------------

I've always noted an ambiguity in the API. There's the halt boolean field which is there and
is set by voteToHalt(), but then there's the isHalted() which can potentially lead to a conflictual
implementation of the concept (the user might not know about the private field halt). 
So I propose: we either put the setHalted() to BasicVertex and give an implementation to Vertex
so the user can ignore it, or we get rid of both isHalted and setHalted together. I don't
see why we should also get rid of voteToHalt(), it has a strong semantical meaning and matches
the original Pregel API. I agree though that the return value of compute might do that as
well.

So: I vote for getting rid of isHalted and setHalted.
                
> GIRAPH-36 missed a couple of liners when passing from Vertex to BasicVertex
> ---------------------------------------------------------------------------
>
>                 Key: GIRAPH-74
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-74
>             Project: Giraph
>          Issue Type: Bug
>          Components: graph
>    Affects Versions: 0.70.0
>            Reporter: Claudio Martella
>            Assignee: Claudio Martella
>             Fix For: 0.70.0
>
>         Attachments: GIRAPH-36-cleaup.diff
>
>
> After GIRAPH-36, in a couple of places Vertex was left instead of BasicVertex. To achieve
the fix a BasicVertex was extended with a new boolean isHalted(boolean state) method that
totally hides boolean halt field. I believe this unifies the voteToHalt() and isHalted() methods
totally hiding the halting management of Vertices (before it was relying on the existence
of boolean halt field).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message