giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jake Mannix" <jake.man...@gmail.com>
Subject Re: Review Request: GIRAPH-64
Date Thu, 03 Nov 2011 05:32:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2700/#review3023
-----------------------------------------------------------


It would be super cool if, like in Mahout and Hadoop, we could print out the set of Vertex
impls / algorithms / actions available.  In Mahout, we have a properties file which we keep
updating.  Even nicer (maybe?) would be to just search the classpath for all classes which
implement BasicVertex, and list them.  Even cooler: have a new abstract method on BasicVertex
"String getHelp()" which GiraphRunner could run via reflection to get the help output for
the task.


/trunk/src/main/java/org/apache/giraph/GiraphRunner.java
<https://reviews.apache.org/r/2700/#comment6742>

    Do these both need to be set?  -of is certainly not required by the framework.  



/trunk/src/main/java/org/apache/giraph/GiraphRunner.java
<https://reviews.apache.org/r/2700/#comment6743>

    both are required?  below you only use them if they are supplied.



/trunk/src/main/java/org/apache/giraph/GiraphRunner.java
<https://reviews.apache.org/r/2700/#comment6744>

    ip vs i ?



/trunk/src/main/java/org/apache/giraph/GiraphRunner.java
<https://reviews.apache.org/r/2700/#comment6745>

    !isQuiet vs verbose... we're defaulting to "verbose" in this case?


- Jake


On 2011-11-03 03:25:11, Jakob Homan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2700/
> -----------------------------------------------------------
> 
> (Updated 2011-11-03 03:25:11)
> 
> 
> Review request for giraph.
> 
> 
> Summary
> -------
> 
> create giraphrunner
> 
> 
> Diffs
> -----
> 
>   /trunk/bin/giraph PRE-CREATION 
>   /trunk/pom.xml 1196926 
>   /trunk/src/main/assembly/assembly.xml PRE-CREATION 
>   /trunk/src/main/java/org/apache/giraph/GiraphRunner.java PRE-CREATION 
>   /trunk/src/main/java/org/apache/giraph/graph/GraphMapper.java 1196926 
> 
> Diff: https://reviews.apache.org/r/2700/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jakob
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message