giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Avery Ching (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GIRAPH-74) GIRAPH-36 missed a couple of liners when passing from Vertex to BasicVertex
Date Thu, 10 Nov 2011 20:09:52 GMT

    [ https://issues.apache.org/jira/browse/GIRAPH-74?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13147975#comment-13147975
] 

Avery Ching commented on GIRAPH-74:
-----------------------------------

Well, if you vote to halt, your compute() is never run again (unless you get a message and
your state is reset at a later superstep).  The halted state after compute() is called is
the one that is final for the vertex for that particular superstep.  Another way of doing
this could be to have compute return a boolean and get rid of setHalted() and voteToHalt().
                
> GIRAPH-36 missed a couple of liners when passing from Vertex to BasicVertex
> ---------------------------------------------------------------------------
>
>                 Key: GIRAPH-74
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-74
>             Project: Giraph
>          Issue Type: Bug
>          Components: graph
>    Affects Versions: 0.70.0
>            Reporter: Claudio Martella
>            Assignee: Claudio Martella
>             Fix For: 0.70.0
>
>         Attachments: GIRAPH-36-cleaup.diff
>
>
> After GIRAPH-36, in a couple of places Vertex was left instead of BasicVertex. To achieve
the fix a BasicVertex was extended with a new boolean isHalted(boolean state) method that
totally hides boolean halt field. I believe this unifies the voteToHalt() and isHalted() methods
totally hiding the halting management of Vertices (before it was relying on the existence
of boolean halt field).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message