giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Avery Ching (Commented) (JIRA)" <>
Subject [jira] [Commented] (GIRAPH-73) A little refactoring
Date Thu, 10 Nov 2011 18:52:51 GMT


Avery Ching commented on GIRAPH-73:

Hi Sebastian, 

Thanks for the refactoring and for taking a look at the code.  Have you looked at the CODE_CONVENTIONS
in the base directory, I see a little bit of weird indenting (not a big deal).  After a quick
pass, looks like you have make some nice improvements in the code.  Now that we have added
Guava, why not take advantage as you have suggested?

Also, regarding 

-              DoubleWritable> vertex = BspUtils.<LongWritable, DoubleWritable, FloatWritable,
-                  DoubleWritable>createVertex(getContext().getConfiguration());
+              DoubleWritable> vertex = BspUtils.createVertex(getContext().getConfiguration());

We have had issues when types aren't specified.  See
and an issue (

Also, were you able to pass unittests locally (mvn test) and on a actual Hadoop instance (mvn
test -Dprop.mapred.job.tracker=<jobtracker>:<jobtracker_port>)?

> A little refactoring
> --------------------
>                 Key: GIRAPH-73
>                 URL:
>             Project: Giraph
>          Issue Type: Improvement
>    Affects Versions: 0.70.0
>            Reporter: Sebastian Schelter
>            Priority: Minor
>         Attachments: GIRAPH-73.patch
> Hi, I'm currently reading Giraph's sources and starting to play with it. I fixed some
small things along the way (like making sure writers are closed, exceptions are logged, etc.),
thought that maybe helpful.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:!default.jspa
For more information on JIRA, see:


View raw message