giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Claudio Martella (Commented) (JIRA)" <>
Subject [jira] [Commented] (GIRAPH-84) Simplify boolean expressions in BspRecordReader
Date Sun, 20 Nov 2011 21:03:52 GMT


Claudio Martella commented on GIRAPH-84:

One more thing, the descriptions mentions two places where the expression could be simplified,
you're missing the nextKeyValue() method. You may want to express it with something like:

return (seenRecord == false ? seenRecord = true : false);

Also, what about using a static final Text ONLY_KEY = Text("only key")? instead of creating
multiple objects?
> Simplify boolean expressions in BspRecordReader
> -----------------------------------------------
>                 Key: GIRAPH-84
>                 URL:
>             Project: Giraph
>          Issue Type: Improvement
>            Reporter: Jakob Homan
>            Assignee: Shaunak Kashyap
>              Labels: newbie
> Twice in BspRecordReader boolean expressions are evaluated with == and can be simplified
to just one liners or variable evaluation.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:!default.jspa
For more information on JIRA, see:


View raw message