giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Avery Ching (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GIRAPH-142) _hadoopBsp should be prefixable via configuration
Date Thu, 09 Feb 2012 23:57:59 GMT

    [ https://issues.apache.org/jira/browse/GIRAPH-142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205066#comment-13205066
] 

Avery Ching commented on GIRAPH-142:
------------------------------------

+1

Some minor formatting changes (spacing and 'if('):

{noformat}
+    public static String getBasePath(Configuration conf) {
+      String result = conf.get(BASE_ZNODE_KEY, "");
+      if(!result.equals("") && !result.startsWith("/"))
+        throw new IllegalArgumentException("Value for " +
+                BASE_ZNODE_KEY + " must start with /: " + result);
+
+        return result;
+    }
+
{noformat}

should be

{noformat}
+    public static String getBasePath(Configuration conf) {
+        String result = conf.get(BASE_ZNODE_KEY, "");
+        if (!result.equals("") && !result.startsWith("/"))
+            throw new IllegalArgumentException("Value for " +
+                BASE_ZNODE_KEY + " must start with /: " + result);
+
+        return result;
+    }
+
{noformat}
                
> _hadoopBsp should be prefixable via configuration
> -------------------------------------------------
>
>                 Key: GIRAPH-142
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-142
>             Project: Giraph
>          Issue Type: Improvement
>    Affects Versions: 0.1.0
>            Reporter: Jakob Homan
>            Assignee: Jakob Homan
>             Fix For: 0.2.0
>
>         Attachments: GIRAPH-142-b.patch, GIRAPH-142.patch
>
>
> In multitennant zookeeper clusters, it would be good to be able to specify the base directory
that's created for the _hadoopBsp znodes.  This would also fix the issue we have with creating
that directory in the source root during tests.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message