giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jakob Homan (Commented) (JIRA)" <>
Subject [jira] [Commented] (GIRAPH-85) Simplify return expression in RPCCommunications::getRPCProxy
Date Sat, 07 Apr 2012 21:34:18 GMT


Jakob Homan commented on GIRAPH-85:

bq. I would like to throw the idea out there that assigning to the "proxy" and other variables
for a moment DOES have a clarity benefit
Generally, I agree with you in all cases except for
{noformat}X x = z.getX()
return x;{noformat}
which is what we've got here.  Anything more complicated like
{noformat}X x = z.getFoo(){noformat}
{noformat}X x = z.getX()/2{noformat}
is probably worth keeping by itself.  The patch looks good, but we need to have you bless
its inclusion into Apache. Can you re-upload #3, with the Apache button checked?  Thanks.
 I'll commit it thereafter.
> Simplify return expression in RPCCommunications::getRPCProxy
> ------------------------------------------------------------
>                 Key: GIRAPH-85
>                 URL:
>             Project: Giraph
>          Issue Type: Improvement
>    Affects Versions: 0.2.0
>            Reporter: Jakob Homan
>            Assignee: Eli Reisman
>              Labels: newbie
>             Fix For: 0.2.0
>         Attachments: GIRAPH-85-3.patch, GIRAPH-85.patch, GIRAPH-85.patch
> Twice in RPCCommunications::getRPCProxy a local variable, proxy, is created and immediately
returned.  We can simplify this to just return the value.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:!default.jspa
For more information on JIRA, see:


View raw message