giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GIRAPH-85) Simplify return expression in RPCCommunications::getRPCProxy
Date Mon, 09 Apr 2012 17:55:19 GMT

    [ https://issues.apache.org/jira/browse/GIRAPH-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250004#comment-13250004
] 

Hudson commented on GIRAPH-85:
------------------------------

Integrated in Giraph-trunk-Commit #98 (See [https://builds.apache.org/job/Giraph-trunk-Commit/98/])
    GIRAPH-85: Simplify return expression in RPCCommunications::getRPCProxy. Contributed by
Eli Reisman. (Revision 1311355)

     Result = SUCCESS
jghoman : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1311355
Files : 
* /incubator/giraph/trunk/CHANGELOG
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/comm/RPCCommunications.java

                
> Simplify return expression in RPCCommunications::getRPCProxy
> ------------------------------------------------------------
>
>                 Key: GIRAPH-85
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-85
>             Project: Giraph
>          Issue Type: Improvement
>    Affects Versions: 0.2.0
>            Reporter: Jakob Homan
>            Assignee: Eli Reisman
>              Labels: newbie
>             Fix For: 0.2.0
>
>         Attachments: GIRAPH-85-3.patch, GIRAPH-85-3.patch, GIRAPH-85.patch, GIRAPH-85.patch
>
>
> Twice in RPCCommunications::getRPCProxy a local variable, proxy, is created and immediately
returned.  We can simplify this to just return the value.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message