giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eli Reisman (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GIRAPH-294) Make LocalityInfoSorter a package private class
Date Mon, 17 Sep 2012 18:29:07 GMT

    [ https://issues.apache.org/jira/browse/GIRAPH-294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13457207#comment-13457207
] 

Eli Reisman commented on GIRAPH-294:
------------------------------------

Lets keep the test. The main purpose of this JIRA is just to get you feeling comfortable with
the Giraph patch submission process. Adding, removing, moving tests would be good practice
for filing a separate JIRA if you like.

The confusion is understandable. In general in Giraph, anything that has a test probably needs
it and/or will still need it whether or not it is user-facing in the API. We run the full
test suite ('mvn verify' command) before submitting any patches to ensure new code doesn't
break the trunk build, so we try to include unit tests of all the code regardless of visibility
in the API.
                
> Make LocalityInfoSorter a package private class
> -----------------------------------------------
>
>                 Key: GIRAPH-294
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-294
>             Project: Giraph
>          Issue Type: Improvement
>            Reporter: Jakob Homan
>            Priority: Minor
>              Labels: newbie
>         Attachments: GIRAPH-294.patch
>
>
> There's no need for LocalityInfoSorter to be public.  It will be quite happy as package
private and shrink the visible footprint of the package.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message