giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Avery Ching" <avery.ch...@gmail.com>
Subject Review Request: GIRAPH-342: Recursive ZooKeeper calls should call progress, dynamic ZooKeeper can skip delete
Date Tue, 25 Sep 2012 05:43:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7245/
-----------------------------------------------------------

Review request for giraph.


Description
-------

Sometimes a long running ZooKeeper deleteExt can take a while, causing a job to fail. This
fixes that issue.

Additionally, this code has a minor optimization to not delete the ZooKeeper structure at
the end of the application if it is a dynamically started ZooKeeper service.


This addresses bug GIRAPH-342.
    https://issues.apache.org/jira/browse/GIRAPH-342


Diffs
-----

  http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/graph/BspService.java
1388628 
  http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/graph/BspServiceMaster.java
1388628 
  http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/zk/ZooKeeperExt.java
1388628 

Diff: https://reviews.apache.org/r/7245/diff/


Testing
-------

mvn clean verify


Thanks,

Avery Ching


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message