giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sergey Vasilinets (JIRA)" <>
Subject [jira] [Commented] (GIRAPH-294) Make LocalityInfoSorter a package private class
Date Mon, 17 Sep 2012 09:41:08 GMT


Sergey Vasilinets commented on GIRAPH-294:

Yep, I doubted too for a long time, what is best practice to make it standalone or to remove
it. Finally, as I understand usual practice is: make unit test for public api, and everything
that should be tested, should be accessible through public api, I didn't find how to test
LocalityInfoSorter through public api, so I decided to remove test.

But If you think this test is important enough to save it, of course, I will move it to standalone
class, cause I'm new to this project.
> Make LocalityInfoSorter a package private class
> -----------------------------------------------
>                 Key: GIRAPH-294
>                 URL:
>             Project: Giraph
>          Issue Type: Improvement
>            Reporter: Jakob Homan
>            Priority: Minor
>              Labels: newbie
>         Attachments: GIRAPH-294.patch
> There's no need for LocalityInfoSorter to be public.  It will be quite happy as package
private and shrink the visible footprint of the package.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

View raw message