giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eli Reisman (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GIRAPH-323) Check if requests are done before calling wait
Date Tue, 11 Sep 2012 18:46:07 GMT

    [ https://issues.apache.org/jira/browse/GIRAPH-323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13453286#comment-13453286
] 

Eli Reisman commented on GIRAPH-323:
------------------------------------

Makes sense to me. I'll leave this a day for folks to jump in but otherwise I think we're
good here. Thanks Maja!

                
> Check if requests are done before calling wait
> ----------------------------------------------
>
>                 Key: GIRAPH-323
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-323
>             Project: Giraph
>          Issue Type: Bug
>            Reporter: Maja Kabiljo
>            Assignee: Maja Kabiljo
>            Priority: Minor
>         Attachments: GIRAPH-323.patch
>
>
> In NettyClient.waitSomeRequests we don't check whether we still have open requests before
calling wait. So we can end up waiting for another waitingRequestMsecs even though we are
done, because last notifyAll was called before we started waiting.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message