From dev-return-4319-apmail-giraph-dev-archive=giraph.apache.org@giraph.apache.org Tue Sep 25 08:19:37 2012 Return-Path: X-Original-To: apmail-giraph-dev-archive@www.apache.org Delivered-To: apmail-giraph-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 67D17DCDA for ; Tue, 25 Sep 2012 08:19:37 +0000 (UTC) Received: (qmail 66862 invoked by uid 500); 25 Sep 2012 08:19:37 -0000 Delivered-To: apmail-giraph-dev-archive@giraph.apache.org Received: (qmail 66696 invoked by uid 500); 25 Sep 2012 08:19:36 -0000 Mailing-List: contact dev-help@giraph.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@giraph.apache.org Delivered-To: mailing list dev@giraph.apache.org Received: (qmail 66664 invoked by uid 99); 25 Sep 2012 08:19:34 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 25 Sep 2012 08:19:34 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 665461C01B0; Tue, 25 Sep 2012 08:19:33 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3179967192055135001==" MIME-Version: 1.0 Subject: Re: Review Request: GIRAPH-337 From: "Eugene Koontz" To: "Eugene Koontz" , "Avery Ching" , "giraph" Date: Tue, 25 Sep 2012 08:19:33 -0000 Message-ID: <20120925081933.18992.517@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Eugene Koontz" X-ReviewGroup: giraph X-ReviewRequest-URL: https://reviews.apache.org/r/7247/ X-Sender: "Eugene Koontz" References: <20120925063458.18992.80706@reviews.apache.org> In-Reply-To: <20120925063458.18992.80706@reviews.apache.org> Reply-To: "Eugene Koontz" --===============3179967192055135001== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7247/#review11878 ----------------------------------------------------------- http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/girap= h/GiraphConfiguration.java Not used in this patch, but I see it in GIRAPH-339. I understand why it= 's here in this patch since this patch was split out from GIRAPH-339. http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/girap= h/benchmark/PageRankBenchmark.java This -N option is nice to have; the default "org.apache.giraph.benchmar= k.PageRankBenchmark" is a bit verbose. http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/girap= h/comm/netty/NettyMasterClient.java We have to pass an additional second (configuration) param here because= context's .getConfiguration() method returns an (overly general) Configura= tion object, but we need a ImmutableClassesGiraphConfiguration object. http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/girap= h/comm/netty/WrappedAdaptiveReceiveBufferSizePredictorFactory.java I don't see this class used anywhere. - Eugene Koontz On Sept. 25, 2012, 6:34 a.m., Avery Ching wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7247/ > ----------------------------------------------------------- > = > (Updated Sept. 25, 2012, 6:34 a.m.) > = > = > Review request for giraph. > = > = > Description > ------- > = > As per Eugene's request. > = > = > This addresses bug GIRAPH-337. > https://issues.apache.org/jira/browse/GIRAPH-337 > = > = > Diffs > ----- > = > http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/g= iraph/GiraphConfiguration.java PRE-CREATION = > http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/g= iraph/GiraphRunner.java 1389724 = > http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/g= iraph/ImmutableClassesGiraphConfigurable.java PRE-CREATION = > http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/g= iraph/ImmutableClassesGiraphConfiguration.java PRE-CREATION = > http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/g= iraph/benchmark/EdgeListVertexPageRankBenchmark.java PRE-CREATION = > http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/g= iraph/benchmark/PageRankBenchmark.java 1389724 = > http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/g= iraph/benchmark/RandomMessageBenchmark.java 1389724 = > http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/g= iraph/benchmark/ShortestPathsBenchmark.java 1389724 = > http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/g= iraph/bsp/BspInputFormat.java 1389724 = > http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/g= iraph/comm/BasicRPCCommunications.java 1389724 = > http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/g= iraph/comm/RPCCommunications.java 1389724 = > http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/g= iraph/comm/SendMessageCache.java 1389724 = > http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/g= iraph/comm/ServerData.java 1389724 = > http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/g= iraph/comm/messages/DiskBackedMessageStore.java 1389724 = > http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/g= iraph/comm/messages/SequentialFileMessageStore.java 1389724 = > http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/g= iraph/comm/messages/SimpleMessageStore.java 1389724 = > http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/g= iraph/comm/netty/NettyClient.java 1389724 = > http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/g= iraph/comm/netty/NettyMasterClient.java 1389724 = > http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/g= iraph/comm/netty/NettyMasterClientServer.java 1389724 = > http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/g= iraph/comm/netty/NettyMasterServer.java 1389724 = > http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/g= iraph/comm/netty/NettyServer.java 1389724 = > http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/g= iraph/comm/netty/NettyWorkerClient.java 1389724 = > http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/g= iraph/comm/netty/NettyWorkerClientServer.java 1389724 = > http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/g= iraph/comm/netty/NettyWorkerServer.java 1389724 = > http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/g= iraph/comm/netty/WrappedAdaptiveReceiveBufferSizePredictorFactory.java PRE-= CREATION = > http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/g= iraph/comm/netty/handler/RequestDecoder.java 1389724 = > http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/g= iraph/comm/netty/handler/RequestServerHandler.java 1389724 = > http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/g= iraph/comm/netty/handler/ResponseClientHandler.java 1389724 = > http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/g= iraph/comm/netty/handler/WorkerRequestReservedMap.java 1389724 = > http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/g= iraph/comm/requests/SendPartitionMessagesRequest.java 1389724 = > http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/g= iraph/comm/requests/SendPartitionMutationsRequest.java 1389724 = > http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/g= iraph/comm/requests/SendVertexRequest.java 1389724 = > http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/g= iraph/comm/requests/WritableRequest.java 1389724 = > http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/g= iraph/examples/GeneratedVertexReader.java 1389724 = > http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/g= iraph/examples/SimpleCheckpointVertex.java 1389724 = > http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/g= iraph/examples/SimplePageRankVertex.java 1389724 = > http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/g= iraph/examples/SimpleSuperstepVertex.java 1389724 = > http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/g= iraph/examples/SimpleVertexWithWorkerContext.java 1389724 = > http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/g= iraph/graph/BspService.java 1389724 = > http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/g= iraph/graph/BspServiceMaster.java 1389724 = > http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/g= iraph/graph/BspServiceWorker.java 1389724 = > http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/g= iraph/graph/BspUtils.java 1389724 = > http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/g= iraph/graph/EdgeListVertex.java 1389724 = > http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/g= iraph/graph/GiraphJob.java 1389724 = > http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/g= iraph/graph/GraphMapper.java 1389724 = > http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/g= iraph/graph/HashMapVertex.java 1389724 = > http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/g= iraph/graph/MasterCompute.java 1389724 = > http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/g= iraph/graph/MasterThread.java 1389724 = > http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/g= iraph/graph/MutableVertex.java 1389724 = > http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/g= iraph/graph/SimpleMutableVertex.java 1389724 = > http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/g= iraph/graph/SimpleVertex.java 1389724 = > http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/g= iraph/graph/Vertex.java 1389724 = > http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/g= iraph/graph/VertexMutations.java 1389724 = > http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/g= iraph/graph/VertexResolver.java 1389724 = > http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/g= iraph/graph/partition/BasicPartitionOwner.java 1389724 = > http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/g= iraph/graph/partition/DiskBackedPartitionStore.java 1389724 = > http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/g= iraph/graph/partition/GraphPartitionerFactory.java 1389724 = > http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/g= iraph/graph/partition/HashMasterPartitioner.java 1389724 = > http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/g= iraph/graph/partition/HashPartitionerFactory.java 1389724 = > http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/g= iraph/graph/partition/HashRangePartitionerFactory.java 1389724 = > http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/g= iraph/graph/partition/Partition.java 1389724 = > http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/g= iraph/graph/partition/RangePartitionOwner.java 1389724 = > http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/g= iraph/graph/partition/RangeSplitHint.java 1389724 = > http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/g= iraph/graph/partition/SimplePartitionStore.java 1389724 = > http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/g= iraph/integration/SuperstepHashPartitionerFactory.java 1389724 = > http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/g= iraph/io/JsonBase64VertexInputFormat.java 1389724 = > http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/g= iraph/io/PseudoRandomVertexInputFormat.java 1389724 = > http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/g= iraph/io/TextVertexInputFormat.java 1389724 = > http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/g= iraph/utils/InternalVertexRunner.java 1389724 = > http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/g= iraph/utils/ReflectionUtils.java 1389724 = > http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/g= iraph/utils/WritableUtils.java 1389724 = > http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/g= iraph/zk/ZooKeeperManager.java 1389724 = > http://svn.apache.org/repos/asf/giraph/trunk/src/test/java/org/apache/g= iraph/BspCase.java 1389724 = > http://svn.apache.org/repos/asf/giraph/trunk/src/test/java/org/apache/g= iraph/TestAggregatorsHandling.java 1389724 = > http://svn.apache.org/repos/asf/giraph/trunk/src/test/java/org/apache/g= iraph/TestAutoCheckpoint.java 1389724 = > http://svn.apache.org/repos/asf/giraph/trunk/src/test/java/org/apache/g= iraph/TestBspBasic.java 1389724 = > http://svn.apache.org/repos/asf/giraph/trunk/src/test/java/org/apache/g= iraph/TestGraphPartitioner.java 1389724 = > http://svn.apache.org/repos/asf/giraph/trunk/src/test/java/org/apache/g= iraph/TestJsonBase64Format.java 1389724 = > http://svn.apache.org/repos/asf/giraph/trunk/src/test/java/org/apache/g= iraph/TestManualCheckpoint.java 1389724 = > http://svn.apache.org/repos/asf/giraph/trunk/src/test/java/org/apache/g= iraph/TestNotEnoughMapTasks.java 1389724 = > http://svn.apache.org/repos/asf/giraph/trunk/src/test/java/org/apache/g= iraph/TestVertexTypes.java 1389724 = > http://svn.apache.org/repos/asf/giraph/trunk/src/test/java/org/apache/g= iraph/comm/ConnectionTest.java 1389724 = > http://svn.apache.org/repos/asf/giraph/trunk/src/test/java/org/apache/g= iraph/comm/RPCCommunicationsTest.java 1389724 = > http://svn.apache.org/repos/asf/giraph/trunk/src/test/java/org/apache/g= iraph/comm/RequestFailureTest.java 1389724 = > http://svn.apache.org/repos/asf/giraph/trunk/src/test/java/org/apache/g= iraph/comm/RequestTest.java 1389724 = > http://svn.apache.org/repos/asf/giraph/trunk/src/test/java/org/apache/g= iraph/comm/TestMessageStores.java 1389724 = > http://svn.apache.org/repos/asf/giraph/trunk/src/test/java/org/apache/g= iraph/examples/TryMultiRpcBindingPortsTest.java 1389724 = > http://svn.apache.org/repos/asf/giraph/trunk/src/test/java/org/apache/g= iraph/graph/TestEdgeListVertex.java 1389724 = > http://svn.apache.org/repos/asf/giraph/trunk/src/test/java/org/apache/g= iraph/graph/partition/TestPartitionStores.java 1389724 = > http://svn.apache.org/repos/asf/giraph/trunk/src/test/java/org/apache/g= iraph/io/TestLongDoubleDoubleAdjacencyListVertexInputFormat.java 1389724 = > http://svn.apache.org/repos/asf/giraph/trunk/src/test/java/org/apache/g= iraph/io/TestTextDoubleDoubleAdjacencyListVertexInputFormat.java 1389724 = > http://svn.apache.org/repos/asf/giraph/trunk/src/test/java/zk/TestZooKe= eperManager.java 1389724 = > = > Diff: https://reviews.apache.org/r/7247/diff/ > = > = > Testing > ------- > = > = > Thanks, > = > Avery Ching > = > --===============3179967192055135001==--