giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maja Kabiljo (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GIRAPH-357) Don't try to combine if there is only one message
Date Sat, 06 Oct 2012 04:54:02 GMT

    [ https://issues.apache.org/jira/browse/GIRAPH-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13470913#comment-13470913
] 

Maja Kabiljo commented on GIRAPH-357:
-------------------------------------

Avery, what are the benefits of disabling sender side combining at this point?

Yes, serializing right away is definitely worth exploring. If it gives significant speedup
for one kind of applications but hurts others we can have it as an option. In current implementation,
when we send the same message to several nodes we'll still do the serialization N times, so
the only possible drawback is the total amount of memory we use at some point. 

I run some experiments with combining less often, but there was no speed change. I'll investigate
a bit more, it seems weird to me that the change on sender gives speedup but on receiver doesn't.
                
> Don't try to combine if there is only one message
> -------------------------------------------------
>
>                 Key: GIRAPH-357
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-357
>             Project: Giraph
>          Issue Type: Improvement
>            Reporter: Maja Kabiljo
>            Assignee: Maja Kabiljo
>         Attachments: GIRAPH-357.patch
>
>
> In SendMessageCache, we call combiner even if we have just one message. Combining is
kind of expensive since we recreate the message object and the list. With default settings
and bigger graph, for PageRankBenchmark there is 10-15% superstep speedup if we don't call
it when we have a single message.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message