giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Avery Ching (JIRA)" <>
Subject [jira] [Commented] (GIRAPH-441) Keep track of connected channels in NettyServer
Date Tue, 04 Dec 2012 18:40:58 GMT


Avery Ching commented on GIRAPH-441:

+1, only minor comment would be to change the comment in to be a bit more
verbose, since it maybe not be clear why this is important.  Here is an example (you can change
it however you like of course)

// Store all connected channels


// Store all connected channels in order to ensure that we can close them on stop(), or else
stop() may hang waiting for the connections to close on their own.

> Keep track of connected channels in NettyServer
> -----------------------------------------------
>                 Key: GIRAPH-441
>                 URL:
>             Project: Giraph
>          Issue Type: Bug
>            Reporter: Maja Kabiljo
>            Assignee: Maja Kabiljo
>         Attachments: GIRAPH-441.patch
> We are still getting a timeout in NettyServer.stop(). We are not calling close on all
the connected channels since we are not keeping track of them.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

View raw message