giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eli Reisman (JIRA)" <>
Subject [jira] [Updated] (GIRAPH-503) Refactor platform-independent CLI argument parsing in GiraphRunner into a separate class
Date Thu, 07 Feb 2013 02:59:13 GMT


Eli Reisman updated GIRAPH-503:

    Attachment: GIRAPH-503-3.patch

Here's an update, will post to RB also. @Claudio: yes! But, this whole thing with these refactors
has been an exercise in not putting too many changes into the same JIRA. Once this is committed,
it will be trivial to add lots more options (and nice help blurbs for them, etc.) in one spot.

@Nitay: One note on my approach here: I moved a bit more of the sanity checking on options
etc. into the new class in this latest rebase. I left a few options to be parsed directly
by GiraphRunner for YARN reasons (i.e. I want some arg parsing to be available to the calling
code so that GiraphYarnRunner and other future Runner modules can do impl-specific stuff while
still collecting the catch-all args in our job's GiraphConfiguration every time. I know it
looks a little funny as-is. Seemed like the easiest way to allow for this without putting
anything platform-specific into the new class.

> Refactor platform-independent CLI argument parsing in GiraphRunner into a separate class
> ----------------------------------------------------------------------------------------
>                 Key: GIRAPH-503
>                 URL:
>             Project: Giraph
>          Issue Type: Improvement
>            Reporter: Eli Reisman
>            Assignee: Eli Reisman
>            Priority: Minor
>         Attachments: GIRAPH-503-1.patch, GIRAPH-503-2.patch, GIRAPH-503-3.patch
> In order to run on non Hadoop MR platforms, we will need to populate the GiraphConfiguration
for our job in a platform-independent way so that all config options are available to whatever
driver class initiates the Giraph job (not just GiraphRunner/GiraphJob.) This also serves
to clean up GiraphRunner in general.
> Passes 'mvn clean install'

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

View raw message