giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alessandro Presta" <alessan...@fb.com>
Subject Review Request: GIRAPH-579: Make it possible to use different out-edges data structures for input and computation
Date Fri, 22 Mar 2013 21:10:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10092/
-----------------------------------------------------------

Review request for giraph.


Description
-------

Introduces an option to specify a different VertexEdges class to be used during edge input.
EdgeStore#moveEdgesToVertices() is now multithreaded (it uses the same number of threads as
used for reading input).


This addresses bug GIRAPH-579.
    https://issues.apache.org/jira/browse/GIRAPH-579


Diffs
-----

  giraph-core/src/main/java/org/apache/giraph/conf/GiraphClasses.java 5090250d93ec73be34d0bd306d00704856a89785

  giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java 6886d5827b3aeece07bbf192390171dc17a05e1d

  giraph-core/src/main/java/org/apache/giraph/conf/GiraphConstants.java ad9073d2431f4e065f373468a54cd2b9baa7c654

  giraph-core/src/main/java/org/apache/giraph/conf/ImmutableClassesGiraphConfiguration.java
4fedc464ce08051cdadb49cc0ac2e8553093ce46 
  giraph-core/src/main/java/org/apache/giraph/edge/EdgeStore.java 234c267661ed884eea1746d0d89056b6d310c88e

  giraph-core/src/main/java/org/apache/giraph/job/GiraphConfigurationValidator.java b08c74d42808790f1eb860183feed436b53c5275

  giraph-core/src/main/java/org/apache/giraph/utils/ConfigurationUtils.java 41238d045c41c8292a8ea70ba899fa51cfe42480

  giraph-core/src/main/java/org/apache/giraph/utils/InternalVertexRunner.java 7e0b955998a5f1890912819fa2ca74fbbf46fedd

  giraph-core/src/test/java/org/apache/giraph/io/TestEdgeInput.java 55c0c86ee7f188d6624def8dd3002962631d6a3f


Diff: https://reviews.apache.org/r/10092/diff/


Testing
-------

1) mvn verify
2) tested at scale both the case where the input edges data structure is the same or a different
one


Thanks,

Alessandro Presta


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message